Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add copy-icon top-left badges code blocks #331

Merged
merged 1 commit into from
Apr 16, 2020
Merged

add copy-icon top-left badges code blocks #331

merged 1 commit into from
Apr 16, 2020

Conversation

ammarnajjar
Copy link
Contributor

Resolves: #330

@ammarnajjar ammarnajjar mentioned this pull request Apr 13, 2020
Closed
asottile
asottile reviewed Apr 13, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's valuable to add copy paste to every code block -- was hoping to just do the badge ones

base.mako Outdated Show resolved Hide resolved
copy-icon.svg Outdated Show resolved Hide resolved
@ammarnajjar ammarnajjar changed the title feat: add copy-icon top-left all code-blocks WIP: add copy-icon top-left badges code blocks Apr 13, 2020
@ammarnajjar ammarnajjar changed the title WIP: add copy-icon top-left badges code blocks add copy-icon top-left badges code blocks Apr 13, 2020
asottile
asottile reviewed Apr 13, 2020
View reviewed changes
copy-icon.svg Outdated Show resolved Hide resolved
base.mako Outdated Show resolved Hide resolved
base.mako Outdated Show resolved Hide resolved
base.mako Outdated Show resolved Hide resolved
base.mako Outdated Show resolved Hide resolved
base.mako Outdated Show resolved Hide resolved
@ammarnajjar ammarnajjar changed the title add copy-icon top-left badges code blocks WIP: add copy-icon top-left badges code blocks Apr 14, 2020
asottile
asottile reviewed Apr 15, 2020
View reviewed changes
template_lib.py Outdated Show resolved Hide resolved
@ammarnajjar ammarnajjar changed the title WIP: add copy-icon top-left badges code blocks add copy-icon top-left badges code blocks Apr 15, 2020
asottile
asottile reviewed Apr 15, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very close! after this round of review I'll fire it up and see how it works on my local machine :)

index.mako Outdated Show resolved Hide resolved
scss/main.scss Outdated Show resolved Hide resolved
template_lib.py Outdated Show resolved Hide resolved
base.mako Outdated Show resolved Hide resolved
asottile
asottile approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good enough for a first pass, we can always circle back and improve it later -- thanks for your patience on working on this!

@asottile asottile merged commit fb95e94 into pre-commit:real_master Apr 16, 2020
@ammarnajjar ammarnajjar deleted the 330-copyable-code-blocks branch April 16, 2020 20:19
@ammarnajjar
Copy link
Contributor Author

ammarnajjar commented Apr 16, 2020 •
edited
Loading

  • Thanks for bearing up with me @asottile
  • I noticed that the icon does not show on https://pre-commit.com/, the class copyable is there though 🤔 , does it have to do with the new created "assets" folder maybe?

@asottile
Copy link
Member

ah, assets need to be whitelisted in deploy, lemme fix that: d0abd97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

copyable code blocks for badges
2 participants
@ammarnajjar @asottile