-
-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare frigate integration #543
Conversation
a few things:
|
ok in progress, https://github.com/rapidsai/frigate/pull/36/files let me know if I'm missing anything. |
@asottile , should be all good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, is there a way to add a quick description and set the hook type to 'helm' ? |
@jrottenberg that's all derived from the |
gotcha, I'll update and wait for the next cron run, thanks again ! |
I had to revert this repo as you broke the build: 3ca6206 |
I see yeah, I can reproduce locally. Not sure what to do from it, the hook classification is derived from https://github.com/pre-commit/identify which in no case will auto detect helm files... and for good reason. I can remove the type, or patch your build script to allow a fallback if |
your configuration is unusable with pre-commit itself -- |
Ah yes of course I'm not using that in the pre-commit (run always regardless of the files changed), I wrongly assumed it was metadata for pre-commit.com. I'll revert so and keep only the description... Sorry about that. |
https://github.com/rapidsai/frigate#pre-commit-hook
Frigate is a very nifty tool << for automatically generating documentation for your Helm charts.>>