New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apeschar/pre-commit-phan to all-repos.yaml #611

Closed

apeschar wants to merge 1 commit into pre-commit:master from apeschar:apeschar-pre-commit-phan

apeschar commented Jan 6, 2022

This PR adds apeschar/pre-commit-phan to the list of hooks, so that users can easily add Phan to their pre-commit checks.


          Add apeschar/pre-commit-phan

47affdc

Member

asottile commented Jan 6, 2022

hi! thanks for the PR, however:

since this is implemented using script / system it isn't particularly useful out of the box for pre-commit users and doesn't provide much if any benefit over a local hook
the repository is not affiliated with pre-commit so it should not use pre-commit- as a name

asottile closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment