improvements/fixes after code review

pre-commit · Feb 26, 2024 · 506480f · 506480f
1 parent 34fc791
commit 506480f
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/.gitignore b/.gitignore
@@ -4,4 +4,3 @@
 /.tox
 /dist
 .vscode/
-.idea
diff --git a/pre_commit/commands/run.py b/pre_commit/commands/run.py
@@ -371,12 +371,8 @@ def run(
     ):
         return 0
     # prevent pushing staged files not committed (#2486)
-    if (
-            args.hook_stage == 'pre-push' and git.get_staged_files()
-    ):
-        logger.error(
-            'Staged files found. Please commit before pushing',
-        )
+    if args.hook_stage == 'pre-push' and git.get_staged_files():
+        logger.error('Staged files found. Please commit before pushing')
         return 1
     # Expose prepare_commit_message_source / commit_object_name
     # as environment variables for the hooks

diff --git a/tests/commands/run_test.py b/tests/commands/run_test.py
@@ -364,12 +364,6 @@ def test_show_diff_on_failure(
             1,
             False,
         ),
-        (
-            {'hook': 'nope', 'hook_stage': 'pre-push'},
-            (b'[ERROR] Staged files found. Please commit before pushing\n',),
-            1,
-            True,
-        ),
         (
             {'all_files': True, 'verbose': True},
             (b'foo.py',),