Skip to content

Commit

Permalink
allow default language_version of system when homedir is /
Browse files Browse the repository at this point in the history
  • Loading branch information
asottile committed Oct 29, 2020
1 parent 711248f commit 62b8d0e
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 2 deletions.
10 changes: 8 additions & 2 deletions pre_commit/languages/helpers.py
Expand Up @@ -37,8 +37,14 @@ def exe_exists(exe: str) -> bool:
common = None

return (
not SHIMS_RE.search(found) and # it is not in a /shims/ directory
common != homedir # it is not in the home directory
# it is not in a /shims/ directory
not SHIMS_RE.search(found) and
(
# the homedir is / (docker, service user, etc.)
os.path.dirname(homedir) == homedir or
# the exe is not contained in the home directory
common != homedir
)
)


Expand Down
6 changes: 6 additions & 0 deletions tests/languages/helpers_test.py
Expand Up @@ -55,6 +55,12 @@ def test_exe_exists_commonpath_raises_ValueError(find_exe_mck, homedir_mck):
assert helpers.exe_exists('ruby') is True


def test_exe_exists_true_when_homedir_is_slash(find_exe_mck):
find_exe_mck.return_value = os.path.normpath('/usr/bin/ruby')
with mock.patch.object(os.path, 'expanduser', return_value=os.sep):
assert helpers.exe_exists('ruby') is True


def test_basic_get_default_version():
assert helpers.basic_get_default_version() == C.DEFAULT

Expand Down

0 comments on commit 62b8d0e

Please sign in to comment.