-
-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook specifies language_version but is using language system problem when upgrading to 2.10.0 #1790
Comments
If you're using in your case, you're inheriting this is an intentional change because your configuration is misconfigured and was leading to confusion |
@asottile I am using the hook repositories because they provide the functionality out of the box so that I don't have to manually write the file matching and any other arguments into the pre-commit configuration file.
How are we supposed to set up Python projects with Django and pylint to work properly with pre-commit in the future? |
Use a repository local hook, as shown in the documentation (there's an example for |
@asottile awesome, thank you for this. My configuration now works great with pre-commit again! |
After upgrading to 2.10.0 I am now facing a hard fail for hooks that are using
system
.For instance:
This used to work fine in 2.9.3 which was my previous version.
My particular setup uses Pipenv, Django, Black, and Pylint.
Now my options are to use either
python
orpython_venv
, none of which actually work for me.I tried to use
additional_dependencies
, which still doesn't work becausepylint_django
requires a configured Django project in order to load the configuration file and similar.Is there a new way of doing this that I am not aware of? I've looked at the docs and can't figure this one out.
Please advise.
Pipfile
:.pre-commit-config.yaml
:pyproject.toml
:The text was updated successfully, but these errors were encountered: