Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning to additional keys in config #1028

Merged
merged 4 commits into from
May 12, 2019
Merged

Add warning to additional keys in config #1028

merged 4 commits into from
May 12, 2019

Conversation

yoavcaspi
Copy link
Contributor

Resolves #965

asottile
asottile reviewed May 11, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's also do one for the CONFIG_SCHEMA as well (the actual top-level)

pre_commit/clientlib.py Outdated Show resolved Hide resolved
pre_commit/clientlib.py Outdated Show resolved Hide resolved
pre_commit/clientlib.py Show resolved Hide resolved
@yoavcaspi
Copy link
Contributor Author

Let me know if there are other issues.

asottile
asottile approved these changes May 12, 2019
View reviewed changes
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

pre_commit/clientlib.py Outdated Show resolved Hide resolved
@asottile asottile merged commit e10b818 into pre-commit:master May 12, 2019
@asottile
Copy link
Member

Thanks again! And thanks to @mitzkia for the assist via cfgv!

@asottile asottile mentioned this pull request May 12, 2019
Closed
@yoavcaspi yoavcaspi deleted the warn_unknown_keys branch May 13, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

warn on unknown keys at the top level
2 participants
@yoavcaspi @asottile