Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MSYS2 Compatibility #1607

Closed
wants to merge 2 commits into from
Closed

Improve MSYS2 Compatibility #1607

wants to merge 2 commits into from

Conversation

danyeaw
Copy link

@danyeaw danyeaw commented Sep 20, 2020

This PR closes part of #1605

It makes two updates:

  1. Update pre-commit to make use of the cygpath command to convert the path to the standard Windows path format after it gets the top-level path from git.
  2. Remove cygwin warnings about incompatible Python+git versions if in the MSYS2 environment

@asottile
Copy link
Member

yeah no sorry, this is just the tip of the iceberg -- one is acting posixlike and one is acting windows-like and sprinkling cygpath is a hack at best. the warning is correct (one is acting like posix and the other is acting like windows) and that will not be supported

@asottile asottile closed this Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danyeaw @asottile