Support Golang major versions #2561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the docs you linked are for a subpath install. pre-commit only supports the convention of the project being at the root. guessing is a surprising behavior that I can't support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golang has a special treatment of major versions. If you go from v1.x.x to v2.x.x you are supposed to put all your code in a v2 directory in the root of the repository. This break pre-commit because pre-commit tries to do a
go install ./...in the root, this fails because now thego.modfile is missing. See this repository for example: https://github.com/nicksnyder/go-i18n.This patch checks if there is a go.mod in the root of the project, if it is not it will scan all subdirectories matching the v[0-9]+ pattern until it finds one containing a go.mod file. This will be the cwd for the install command.
For reference:
https://go.dev/doc/modules/major-version