/ pre-commit Public
Adapt extension of R executable depending on os #2605
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
Closes #2599 by adding ensuring
.exesuffix to the
Rscriptexecutable on Windows. But I don't understand if that change breaks current uses or if some versions of Windows / shells just add `.exe. when it's missing while others don't.
Also, I am not sure if it also closes lorenzwalthert/precommit#441 or if the added
~in the Rscript path is of any harm or not and
ctypes.windll.kernel32.GetLongPathNameWfrom the standard library is needed to use get full path.