Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adhere to XDG specification for cache dir. #602

Merged
merged 1 commit into from
Sep 7, 2017
Merged

Adhere to XDG specification for cache dir. #602

merged 1 commit into from
Sep 7, 2017

Conversation

asottile
Copy link
Member

@asottile asottile commented Sep 4, 2017

Resolves #562
CC @nagromc

chriskuehl
chriskuehl approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@chriskuehl chriskuehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems cool to me. will need to update some travis configs to cache the right directory, but overall i think ~/.cache/pre-commit is a better place for it to live anyway

@asottile
Copy link
Member Author

asottile commented Sep 5, 2017

Cool, I have some plans to do some larger changes and get to "v1.0.0", I think I'll wait to merge this until I'm ready to do that -- maybe a few days.

@asottile asottile merged commit 9ff6818 into master Sep 7, 2017
@asottile asottile deleted the xdg_cache_dir branch September 7, 2017 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskuehl chriskuehl chriskuehl approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asottile @chriskuehl