Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow autoupdate --repo to be specified multiple times #713

Merged
merged 1 commit into from Feb 25, 2018
Merged

Allow autoupdate --repo to be specified multiple times #713

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pre_commit/commands/autoupdate.py
View file
Open in desktop
Expand Up @@ -106,7 +106,7 @@ def _write_new_config_file(path, output):
f.write(to_write)


def autoupdate(runner, tags_only, repo=None):
def autoupdate(runner, tags_only, repos=()):
"""Auto-update the pre-commit config to the latest versions of repos."""
migrate_config(runner, quiet=True)
retv = 0
Expand All @@ -120,7 +120,7 @@ def autoupdate(runner, tags_only, repo=None):
is_local_repo(repo_config) or
is_meta_repo(repo_config) or
# Skip updating any repo_configs that aren't for the specified repo
repo and repo != repo_config['repo']
repos and repo_config['repo'] not in repos
):
output_repos.append(repo_config)
continue
Expand Down
5 changes: 3 additions & 2 deletions pre_commit/main.py
View file
Open in desktop
Expand Up @@ -168,7 +168,8 @@ def main(argv=None):
),
)
autoupdate_parser.add_argument(
'--repo', help='Only update this repository.',
'--repo', dest='repos', action='append', metavar='REPO',
help='Only update this repository -- may be specified multiple times.',
)

migrate_config_parser = subparsers.add_parser(
Expand Down Expand Up @@ -251,7 +252,7 @@ def main(argv=None):
return autoupdate(
runner,
tags_only=not args.bleeding_edge,
repo=args.repo,
repos=args.repos,
)
elif args.command == 'migrate-config':
return migrate_config(runner)
Expand Down
4 changes: 2 additions & 2 deletions tests/commands/autoupdate_test.py
View file
Open in desktop
Expand Up @@ -138,7 +138,7 @@ def test_autoupdate_out_of_date_repo_with_correct_repo_name(
runner = Runner('.', C.CONFIG_FILE)
before = open(C.CONFIG_FILE).read()
repo_name = 'file://{}'.format(out_of_date_repo.path)
ret = autoupdate(runner, tags_only=False, repo=repo_name)
ret = autoupdate(runner, tags_only=False, repos=(repo_name,))
after = open(C.CONFIG_FILE).read()
assert ret == 0
assert before != after
Expand All @@ -158,7 +158,7 @@ def test_autoupdate_out_of_date_repo_with_wrong_repo_name(
runner = Runner('.', C.CONFIG_FILE)
before = open(C.CONFIG_FILE).read()
# It will not update it, because the name doesn't match
ret = autoupdate(runner, tags_only=False, repo='wrong_repo_name')
ret = autoupdate(runner, tags_only=False, repos=('wrong_repo_name',))
after = open(C.CONFIG_FILE).read()
assert ret == 0
assert before == after
Expand Down