Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log::Any::Proxy does not pass @_ #9

Closed
dagolden opened this issue Jan 2, 2015 · 0 comments
Closed

Log::Any::Proxy does not pass @_ #9

dagolden opened this issue Jan 2, 2015 · 0 comments

Comments

@dagolden
Copy link

dagolden commented Jan 2, 2015

(Issue details were lost during repo re-construction; this is a summary of
the conversation to the best of my recollection.)

  • Gelu Lupaş opened an issue that Log::Any::Proxy logging functions only pass
    the first argument to the adapter.
  • I replied that that behavior isn't documented and is inconsistent across
    adapters anyway
  • After some back and forth (which identified other, unrelated bugs), I
    investigated existing adapter behavior. Some pass all arguments; some don't.
    Some underlying loggers vary as well: some concatenate with a space,
    others don't.
  • I proposed that Log::Any::Proxy concatenate multiple arguments with
    a space for consistency.
  • Gelu thought that was not the most flexible solution and was not inclined
    to maintain his adapter (Log::Any::Adapter::Handler) and I offer to take
    over maintenance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants