You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The t/allow_origin.t test started to fail on my smokers:
Configuration file "/home/cpansand/.cpan/build/2017011206/Mercury-0.011-0/blib/t/share/allow_origin.conf" missing, maybe you need to create it?
t/allow_origin.t .......
Dubious, test returned 2 (wstat 512, 0x200)
No subtests run
Statistical analysis suggests that this happens with newer Mojolicious versions:
This does seem to be tangentially-related to the Mojolicious change in 7.18 which adds the new Mojo::File API, but it seems more to be one of those things where it accidentally worked in the Mercury test, and it should indeed never have worked correctly: Mojolicious::Plugin::Config has always looked for config files "relative to the application home directory" (unless they were absolute paths). That somehow the test worked before this is surprising (and incorrect), though why I was unable to reproduce it using my standard dev environment was obvious (given an app module path of lib/Mercury.pm, the "home" directory gets set to lib/.., which meant that t/share/allow_origin.conf was correct).
So, this is an easy fix, and I'll have a new release out shortly. Thanks for the report and the analysis!
[Fixed]
- Fixed allow_origin.t test failing on new versions of Mojolicious
due to an invalid assumption in the test. Previously it was
accidentally working, now it is deliberately working. Thanks
@eserte for the report! [Github #37]
The t/allow_origin.t test started to fail on my smokers:
Statistical analysis suggests that this happens with newer Mojolicious versions:
The text was updated successfully, but these errors were encountered: