Fixes for MySQL strict mode and for object creation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 5, 2019 13:01
Also got rid of the $mysql->max_connections(1) since it wasn't doing what it was intended to do (only decreased the size of cached connection for reuse, not the total number of allowed active connections).
Re-use $db where it makes sense, instead of getting a new DB connection via $mysql->db. The “reset” sub still gets separate connections, in case there’s an opportunity for parallel async activity.
preaction
force-pushed
the
master
branch
5 times, most recently
from
95a8a76
to
2fedaef
Compare
|
I could not seem to get Travis tests to fail before this patch, so I'm not sure we'll have regression coverage... But I merged this and will tag a release presently. Thanks! |
preaction
added a commit
that referenced
this pull request
Aug 11, 2019
[Added]
- Added Travis tests for more MySQL and MariaDB versions. Thanks
@paultcochrane for the initial work on this. (Github #1)
- You can now pass in a connected Mojo::mysql instance to the backend
to make it use that (instead of creating its own instance). This can
help make sure that concurrent connections are limited and reused.
Thanks @larryl & @GrantStreetGroup for contributing this!
(Github #22)
[Fixed]
- Fixed SQL errors under MySQL strict mode (Specifically, the SQL
GROUP BY columns need to be specified as SELECTed). Thanks @larryl
& @GrantStreetGroup! (Github #22)
- Fixed backend creating dozens of connections to MySQL. Now basic
operations should be far more efficient. Thanks @larryl
& @GrantStreetGroup! (Github #22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.