Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of per-env as per #1062 #40

Merged
merged 2 commits into from Apr 6, 2020
Merged

Removal of per-env as per #1062 #40

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
763c07f
per-env removed
daniel-sudz Apr 6, 2020
694b23c
Update package.json
ForsakenHarmony Apr 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions template/package.json
View file
Open in desktop
Expand Up @@ -4,7 +4,7 @@
"version": "0.0.0",
"license": "MIT",
"scripts": {
"start": "per-env",
"start": "preact watch",
"start:production": "npm run -s serve",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also rename this to serve?

"start:development": "npm run -s dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this in favour or start?

"build": "preact build",
Expand All @@ -27,7 +27,6 @@
"identity-obj-proxy": "^3.0.0",
"jest": "^24.9.0",
"jest-preset-preact": "^1.0.0",
"per-env": "^1.0.2",
"preact-cli": "^3.0.0-rc.6",
"preact-render-spy": "^1.2.1",
"sirv-cli": "^0.4.5"
Expand Down