Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document missing inputs? #27

Closed
brandonweiss opened this issue May 31, 2020 · 3 comments
Closed

Document missing inputs? #27

brandonweiss opened this issue May 31, 2020 · 3 comments

Comments

@brandonweiss
Copy link

Hey! I was reading through the README and couldn’t quite figure out how this action worked… there didn’t seem to be any configuration about where to look for the output of the build. I thought maybe it automagically figured it out by only comparing untracked file (not checked in to Git) Then I read through the source and found there are pattern and exclude inputs.

Is there a reason those aren’t documented in action.yml and the README? 🤔
@brandonweiss
Copy link
Author

Actually after testing it out it seems I can’t use the pattern or exclude inputs because they’re not defined in the action.yml 🤔 Does that mean this action can’t be used unless your bundle happens to be located in a “dist” folder?

@brandonweiss
Copy link
Author

Oh, I just discovered #24 🤦‍♂️

@developit
Copy link
Member

Fixed in the latest v2 (v2.0.1)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandonweiss @developit