Refactor: Remove 'sw-debug.js' from prod output #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3804d07 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
Dec 2, 2020
rschristian
changed the title
prateekbh
approved these changes
Dec 2, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Edit to build output
Did you add tests for your changes?
I updated existing tests
Summary
Closes #1477
User wanted to keep
sw-debug.jsout of builds when specifying--no-sw. We already didn't use the debug service worker on prod builds, but copied the file regardless.This disables the debug service worker from being copied on production builds. I could add another check to make sure it's not copied on dev builds, but I feel like that's unnecessary. So long as the logic to keep it from being used is sound, we don't really need to worry about the copying of an extra file for dev.
Does this PR introduce a breaking change?
No