Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove size tracking of SSR build #1434

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

rschristian
Copy link
Member

What kind of change does this PR introduce?

Minor refactor

Did you add tests for your changes?

No

Summary

#1407 introduced a size-plugin-ssr.json. This is rather pointless to measure and doesn't have much value to the end user. This PR removes it.

Does this PR introduce a breaking change?

No

@rschristian rschristian requested a review from a team as a code owner September 21, 2020 21:48
@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2020

🦋 Changeset detected

Latest commit: d35055a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@ForsakenHarmony ForsakenHarmony merged commit ab84275 into preactjs:master Sep 28, 2020
@preact-bot preact-bot mentioned this pull request Sep 28, 2020
@rschristian rschristian deleted the fix/removeSsrTracking branch September 28, 2020 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants