Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add CLI tests for all subcommands & most of their flags #1738

Merged
merged 2 commits into from
Nov 19, 2022

Conversation

rschristian
Copy link
Member

What kind of change does this PR introduce?

tests

Did you add tests for your changes?

Yes

Summary

Originally part of #1699 but extracted out to simplify the diff.

Just adds a whole bunch of tests and fixes some blind spots. Adds new test suites for info and list commands as well as adds tests for nearly every CLI flag. I did skip some due to being slow (like --install for create) or already being covered well enough (--cwd for both build & create basically runs our test suite).

Does this PR introduce a breaking change?

No

@rschristian rschristian requested a review from a team as a code owner August 21, 2022 05:56
@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2022

⚠️ No Changeset found

Latest commit: 3d030a4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

packages/cli/tests/watch.test.js Outdated Show resolved Hide resolved
@rschristian rschristian force-pushed the fix/test-suite-gaps branch 2 times, most recently from 67d4f78 to eef90b8 Compare November 19, 2022 00:55
@rschristian rschristian merged commit 12e230d into master Nov 19, 2022
@rschristian rschristian deleted the fix/test-suite-gaps branch November 19, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants