refactor: prune flags #1752

rschristian · 2022-12-13T07:17:54Z

What kind of change does this PR introduce?

Refactor

Did you add tests for your changes?

Modified existing

Summary

Removed

--json
- This always felt a bit niche and unnecessary, considering we have an in-built bundle analyzer (that's the de facto of the ecosystem, AFAIK). I'm not too set on removing, but figured it's faster to revert if unwanted than wait for a +1 on removal.
--brotli
- This appears to have been broken for a while with no complaints. I think it's pretty niche and better left up to users to figure out if they need it.
--rhl
- Was an undocumented alias for --refresh.

Altered

--inline-css
- All other flags are camelCased, this is the odd one out. Switched it in the docs & CLI, but I did add an alias so --inline-css will continue to work without issues. No breaking changes here.

Does this PR introduce a breaking change?

Yes, will require stripping out the removed flags if in use

changeset-bot · 2022-12-13T07:17:57Z

🦋 Changeset detected

Latest commit: f0bea74

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
preact-cli	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

rschristian · 2022-12-13T07:18:57Z

README.md

-    --brotli           Adds brotli redirects to the service worker  (default false)
-    --inline-css       Adds critical css to the prerendered markup  (default true)
+    --template         Path to custom HTML template (default 'src/template.html')
+    --inlineCss        Adds critical css to the prerendered markup  (default true)
+    --analyze          Launch interactive Analyzer to inspect production bundle(s) (default false)


--template and --analyze were just moved to match the order for preact watch's flags -- ordering consistency is just a nice-to-have and I felt dev's order was better.

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

* Chore: Updating html-webpack-plugin to v4 (#1608) * chore: Correcting changeset * feat: webpack v5 (#1645) * feat: webpack-v5 * test: Update tests * docs: Updating docs to reflect changes * chore: Removing optimize-plugin local patch * refactor: Determine CSS module by filename, not directory (#1714) * refactor: Determine CSS module by filename, not directory * docs: Adding changeset * refactor: Project creation pull from templates 'main' branch * test: Updating tests * revert: Accidentally removed log message * refactor: Extracting project creation out to own package (#1708) * refactor: Extracting out project creation to own package * docs: Adding changeset * refactor: Misc edits to common deps & workspace helper scripts * test: Fixing 'create' test suite * ci: Increase minimum Node version * chore: Fix typos * docs: Update ReadMe instructions * chore: Better (and untaken) package name * docs: Update changeset * test: Update 'create' test suite & build output hashes * docs: Expounding upon changeset * refactor: Drop Preact 8 support (#1716) * refactor: Drops support for Preact v8 * docs: Adding changeset * refactor: Switch to automatic runtime JSX transform (#1725) * refactor: Switch over to automatic runtime transform for JSX * test: Removing `h` imports from test suite * docs: Adding changeset * docs: Adding readme for create-cli (#1728) * docs: Adding readme for create-cli * feat: Initial publish * fix: Correcting broken readme links * refactor: Disable hashing ssr-build's css (#1733) * refactor: Disable hashing ssr-build's css * docs: Adding changeset * test: Fix unrelated change from altered template * refactor: Remove `--preload` flag (#1737) * refactor: Removes `--preload` flag & functionality * docs: Adding changeset * docs: Updating readme for removal of preload * refactor: Separate internal concepts of config and env (#1734) * refactor: Separate internal concepts of config and env * docs: Adding changeset * refactor: prune flags (#1752) * refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset * feat: Improved errors and warnings (#1758) * refactor: Better root error handling * refactor: Switch prerender plugin to be async for error gen * refactor: Simplify & improve compilation messages * refactor: Bump Node version, remove `src` arg in build & watch, and misc housekeeping (#1753) * refactor: Drop rimraf for built-in fs.rm * refactor: Drop src argument in build & watch cmds * refactor: Extract info cmd from CLI entrypoint * refactor: Remove update-notifier * refactor: Switch from fs.promises to fs/promises * docs: Adding changeset * refactor: Move EJS into user templates (`template.html`) (#1768) * refactor: Merging EJS templates and switcing preferred template extension to .ejs * test: Fixing test suite to reflect latest changes * chore: Cleaning * docs: Updating ReadMe * docs: Adding changeset * refactor: Add error message for <% preact.(head|body)End %> * chore: Publishing cli & create-cli * Refactor: Enable Prefresh by Default (#1772) * refactor: Enables HMR via Prefresh by default * docs: Adding changeset * test: Updating tests to reflect changes to templates * refactor: Remove Critters (perhaps temporarily) (#1778) * refactor: Remove Critters (perhaps temporarily) * docs: Adding changeset * chore: Publish v4.0.0-next.2 * refactor: Vendor Critters so that 7c811ac can be reverted (#1780) * docs: Remove CLI beta note from readme * docs: Bump minimum Node version listed in readme

rschristian requested a review from a team as a code owner December 13, 2022 07:17

rschristian commented Dec 13, 2022

View reviewed changes

rschristian force-pushed the next branch from dfe91b8 to a14a53a Compare December 13, 2022 07:24

refactor: Revise inconsistent, unused, and deprecated flags

c729d98

rschristian force-pushed the refactor/prune-flags branch from 3e16497 to 5ef3ad1 Compare December 13, 2022 07:27

docs: Adding changeset

f0bea74

rschristian force-pushed the refactor/prune-flags branch from 5ef3ad1 to f0bea74 Compare December 13, 2022 07:35

rschristian merged commit 1dedabc into next Dec 13, 2022

rschristian deleted the refactor/prune-flags branch December 13, 2022 07:41

rschristian added a commit that referenced this pull request Dec 18, 2022

refactor: prune flags (#1752)

576afc8

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 20, 2022

refactor: prune flags (#1752)

ca3d598

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 20, 2022

refactor: prune flags (#1752)

7ff2eba

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 20, 2022

refactor: prune flags (#1752)

8dc6a0c

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 20, 2022

refactor: prune flags (#1752)

bbe05fc

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 21, 2022

refactor: prune flags (#1752)

51b31b8

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 22, 2022

refactor: prune flags (#1752)

acb0882

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 23, 2022

refactor: prune flags (#1752)

b54a31f

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 24, 2022

refactor: prune flags (#1752)

2c7705c

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 24, 2022

refactor: prune flags (#1752)

e0db9ce

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Dec 24, 2022

refactor: prune flags (#1752)

19cdf3e

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 6, 2023

refactor: prune flags (#1752)

55bca37

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 6, 2023

refactor: prune flags (#1752)

a56de2e

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 6, 2023

refactor: prune flags (#1752)

9cb1bca

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 6, 2023

refactor: prune flags (#1752)

a937f59

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 6, 2023

refactor: prune flags (#1752)

67aea29

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 7, 2023

refactor: prune flags (#1752)

23e9e70

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 7, 2023

refactor: prune flags (#1752)

ad3cc0c

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 7, 2023

refactor: prune flags (#1752)

eb787f4

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 8, 2023

refactor: prune flags (#1752)

4588fd6

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 9, 2023

refactor: prune flags (#1752)

d0d113a

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 9, 2023

refactor: prune flags (#1752)

9a0f954

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 9, 2023

refactor: prune flags (#1752)

c51f605

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 9, 2023

refactor: prune flags (#1752)

c82e17c

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 16, 2023

refactor: prune flags (#1752)

ea5dcf4

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 31, 2023

refactor: prune flags (#1752)

2fbb953

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 31, 2023

refactor: prune flags (#1752)

750604a

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 31, 2023

refactor: prune flags (#1752)

98c8dba

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Jan 31, 2023

refactor: prune flags (#1752)

c878382

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Feb 2, 2023

refactor: prune flags (#1752)

3d1b920

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Oct 10, 2023

refactor: prune flags (#1752)

3efac4b

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Oct 10, 2023

refactor: prune flags (#1752)

c20eb59

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Oct 10, 2023

refactor: prune flags (#1752)

62341dc

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

rschristian added a commit that referenced this pull request Oct 10, 2023

refactor: prune flags (#1752)

5ea83c3

* refactor: Revise inconsistent, unused, and deprecated flags * docs: Adding changeset

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: prune flags #1752

refactor: prune flags #1752

rschristian commented Dec 13, 2022 •

edited

Loading

changeset-bot bot commented Dec 13, 2022 •

edited

Loading

rschristian Dec 13, 2022

refactor: prune flags #1752

refactor: prune flags #1752

Conversation

rschristian commented Dec 13, 2022 • edited Loading

Removed

Altered

changeset-bot bot commented Dec 13, 2022 • edited Loading

🦋 Changeset detected

rschristian Dec 13, 2022

Choose a reason for hiding this comment

rschristian commented Dec 13, 2022 •

edited

Loading

changeset-bot bot commented Dec 13, 2022 •

edited

Loading