Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always infer debug mode from flag #468

Merged
merged 3 commits into from Mar 6, 2023
Merged

Always infer debug mode from flag #468

merged 3 commits into from Mar 6, 2023

Conversation

marvinhagemeister
Copy link
Member

@marvinhagemeister marvinhagemeister commented Mar 6, 2023

I can't exactly reconstruct why I accidentally uploaded a debug build for chrome yesterday when cutting a new version (see #467 ). My assumption is that I ran the run:chrome command which builds a debug extension and loads it into a fresh chrome instance. I typically always use that just before publishing to make a final smoke test check. Normally, I run the build:chrome command once that's done but it looks like I forgot that yesterday. That's very likely what happened yesterday.

To prevent such accidents in the future this PR makes a couple of changes:

  • Always use separate directories for debug and non-debug builds
  • Always add -debug suffix to zipped debug extensions
  • Use a global variable that must be injected to toggle debug mode instead of relying on process.env.DEBUG

@marvinhagemeister marvinhagemeister marked this pull request as ready for review March 6, 2023 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant