Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: RTS peer dep w/ Vite #13

Merged
merged 2 commits into from
Apr 6, 2024
Merged

fix: RTS peer dep w/ Vite #13

merged 2 commits into from
Apr 6, 2024

Conversation

rschristian
Copy link
Member

@rschristian rschristian commented Apr 5, 2024

Fixes: preactjs/preset-vite#117

Vite's pretty weird here; when RTS isn't installed...

  • and the default export is used, it'll have no problem
  • and a wildcard import is used, it'll emit a warning
  • and a named import is used, it'll fall right over and fail to build (as the linked issue shows)

Alternatively, maybe it's worth reverting making RTS an optional peer dep altogether as there's also this funky issue

Edit: Worth looking at in the next major, maybe keep /prerender as the only subpath export. I don't want to break anything now though.

@rschristian rschristian merged commit 1647bd7 into main Apr 6, 2024
@rschristian rschristian deleted the fix/vite-peer-deps branch April 6, 2024 08:58
@rschristian rschristian mentioned this pull request Apr 11, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Freshly generated project doesn't build
2 participants