fix: Ensure loadEnd is called even without route navigation
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup for
onLoadEndis problematic as we also need to be able to trigger it without route change, such as a page load/refresh. preact-www displays this issue and is locked to an older version because of this, as the loading bar will run from initial page load until the user navigates elsewhere.This adds tests for
onLoadStart/onLoadEnd/onRouteChangefor page load & navigation, as well as a test to ensure we haven't regressed to callingonLoadEndon every render, which was the reason for this setup.