Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 5.0.0 is not compatible with preact@8.4.2 #76

Closed
Mizumaki opened this issue Mar 13, 2019 · 3 comments
Closed

version 5.0.0 is not compatible with preact@8.4.2 #76

Mizumaki opened this issue Mar 13, 2019 · 3 comments

Comments

@Mizumaki
Copy link

Currently when you install preact (npm install preact), preact@8.4.2 is installed.

However, when you install preact-render-to-string (npm install preact-render-to-string), preact-render-to-string@5.0.0 is installed.

And version 5.0.0 is not compatible with preact@8.4.2, because of VNode format.

Please fix the default version when npm install preact-render-to-string.
Thanks.

@marvinhagemeister
Copy link
Member

@developit We could change the npm tags to make 5.0.0 point to next and the 4.x release point to latest

@developit
Copy link
Member

We'll have to re-tag. The peerDependencies are already set to limit render-to-string@5 to use with preact 10+:
https://github.com/developit/preact-render-to-string/blob/master/package.json#L61-L63

Problem is that 5.0.0 wasn't released as an alpha.

@developit
Copy link
Member

This has been addressed. Usage with preact@next now requires installing preact-render-to-string@next:
Screen Shot 2019-03-14 at 3 34 23 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants