Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the regex breaking the tests #263

Merged
merged 1 commit into from Nov 8, 2022
Merged

fix the regex breaking the tests #263

merged 1 commit into from Nov 8, 2022

Conversation

JoviDeCroock
Copy link
Member

The glob pattern introduced in https://github.com/preactjs/preact-render-to-string/pull/257/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R35 broke the tests running correctly, this moves stuff to their own dir and tweaks test running

@changeset-bot
Copy link

changeset-bot bot commented Nov 8, 2022

⚠️ No Changeset found

Latest commit: 97c8eb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

@JoviDeCroock JoviDeCroock merged commit 2995c16 into master Nov 8, 2022
@JoviDeCroock JoviDeCroock deleted the fix-tests-running branch November 8, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants