Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect second default export from jsx.d.ts #329

Merged
merged 1 commit into from Jan 11, 2024

Conversation

acelaya
Copy link
Contributor

@acelaya acelaya commented Jan 11, 2024

This PR fixes #328, by removing the second default export from jsx.d.ts

Copy link

changeset-bot bot commented Jan 11, 2024

🦋 Changeset detected

Latest commit: b7cfebd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
preact-render-to-string Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changeset and we're good to go

@acelaya
Copy link
Contributor Author

acelaya commented Jan 11, 2024

Just needs a changeset and we're good to go

Just pushed it.

Not related with this PR, but I had to change "baseBranch": "master" to "baseBranch": "main" in changeset's config file, in order to make changeset cli work.

I then reverted it to avoid introducing unrelated changes here, but just FYI.

@JoviDeCroock JoviDeCroock merged commit 0a0d0ce into preactjs:main Jan 11, 2024
1 check passed
@github-actions github-actions bot mentioned this pull request Jan 11, 2024
@acelaya acelaya deleted the fix-jsx-type-definition branch January 11, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect jsx type definition
2 participants