Handle the class attribute removal

preactjs · Oct 16, 2019 · 0c3c03a · 0c3c03a
1 parent 9434a06
commit 0c3c03a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/diff/index.js b/src/diff/index.js
@@ -240,7 +240,7 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
 			if (oldProps === EMPTY_OBJ) {
 				oldProps = {};
 				for (let i=0; i<dom.attributes.length; i++) {
-					oldProps[dom.attributes[i].name] = dom.attributes[i].value;
+					oldProps[dom.attributes[i].name] = dom.attributes[i].value || undefined;
 				}
 			}
 

diff --git a/src/diff/props.js b/src/diff/props.js
@@ -103,7 +103,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
 				dom[name] = '';
 
 				// And remove the attribute entirely
-				dom.removeAttribute(name);
+				dom.removeAttribute(name == 'className' ? 'class' : name);
 			}
 		}
 		else {

diff --git a/test/browser/render.test.js b/test/browser/render.test.js
@@ -481,7 +481,7 @@ describe('render()', () => {
 			);
 
 			render(<App />, scratch);
-			expect(scratch.innerHTML).to.equal('<div class=""><span>Bye</span></div>');
+			expect(scratch.innerHTML).to.equal('<div><span>Bye</span></div>');
 		});
 
 		it('should remove class attributes', () => {
@@ -495,7 +495,7 @@ describe('render()', () => {
 			expect(scratch.innerHTML).to.equal('<div class="hi"><span>Bye</span></div>');
 
 			render(<App />, scratch);
-			expect(scratch.innerHTML).to.equal('<div class=""><span>Bye</span></div>');
+			expect(scratch.innerHTML).to.equal('<div><span>Bye</span></div>');
 		});
 
 		it('should remove old styles', () => {