Skip to content

Commit

Permalink
Remove TODO comments
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewiggins committed Feb 17, 2020
1 parent 3ede3a7 commit 19eaa94
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/diff/children.js
Expand Up @@ -140,7 +140,6 @@ export function diffChildren(
// can clean up the property
childVNode._nextDom = undefined;

// TODO: Investigate removing this `if` to save bytes
if (oldVNode._newIndex != null) {
oldChildren[oldVNode._newIndex] = undefined;
}
Expand Down Expand Up @@ -172,8 +171,8 @@ export function diffChildren(

// Since this code path means oldVNode moved up in the tree,
// remove oldVNode from oldChildren so that getDomSibling doesn't see it
// when searching for siblings
// TODO: Investigate removing this `if` to save bytes
// when searching for siblings. This mimics actually moving the DOM like
// insertBefore would do
if (oldVNode._newIndex != null) {
oldChildren[oldVNode._newIndex] = undefined;
}
Expand Down

0 comments on commit 19eaa94

Please sign in to comment.