Merge d0215a1 into 76f942f

preactjs · Feb 11, 2020 · 5f06075 · 5f06075
2 parents 76f942f + d0215a1
commit 5f06075
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/src/diff/index.js b/src/diff/index.js
@@ -338,6 +338,11 @@ function diffElementNodes(
 					dom.innerHTML = (newHtml && newHtml.__html) || '';
 				}
 			}
+
+			if (newVNode.type === 'select') {
+				newProps.onChange = newProps.onInput;
+				newProps.onInput = undefined;
+			}
 		}
 
 		diffProps(dom, newProps, oldProps, isSvg, isHydrating);

diff --git a/test/browser/select.test.js b/test/browser/select.test.js
@@ -46,6 +46,21 @@ describe('Select', () => {
 		expect(scratch.firstChild.value).to.equal('B');
 	});
 
+	it('should alias onInput to onChange', () => {
+		const func = () => {};
+		render(
+			<select onInput={func}>
+				<option value="A">A</option>
+				<option value="B">B</option>
+				<option value="C">C</option>
+			</select>,
+			scratch
+		);
+
+		expect(scratch.firstChild._listeners.change).to.not.be.undefined;
+		expect(scratch.firstChild._listeners.input).to.be.undefined;
+	});
+
 	it('should work with multiple selected', () => {
 		function App() {
 			return (