suspense fix: Cannot read property 'insertBefore' of undefined

preactjs · Sep 24, 2023 · 8029d17 · 8029d17
1 parent 64be3cb
commit 8029d17
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/compat/src/suspense.js b/compat/src/suspense.js
@@ -70,7 +70,7 @@ function detachedClone(vnode, detachedParent, parentDom) {
 }
 
 function removeOriginal(vnode, detachedParent, originalParent) {
-	if (vnode) {
+	if (vnode && originalParent) {
 		vnode._original = null;
 		vnode._children =
 			vnode._children &&

diff --git a/compat/test/browser/suspense.test.js b/compat/test/browser/suspense.test.js
@@ -2100,4 +2100,29 @@ describe('suspense', () => {
 			expect(scratch.innerHTML).to.eql(`<p>hello new world</p>`);
 		});
 	});
+
+	it('originalParent undefined should not crash', () => {
+		const C = lazy(async () => {
+			await new Promise(r => setTimeout(r, 1000));
+			const Comp = () => <p>hello world</p>;
+			return {
+				default: Comp
+			};
+		});
+
+		const App = () => {
+			const [, setTest] = useState(false);
+			useLayoutEffect(() => setTest(true), []);
+
+			return (
+				<Suspense fallback={<div />}>
+					<div>
+						<C />
+					</div>
+				</Suspense>
+			);
+		};
+
+		render(<App />, scratch);
+	});
 });