Fix inconsistent test spy calls

preactjs · Nov 11, 2020 · 8133738 · 8133738
1 parent 94bde4f
commit 8133738
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 13 deletions.
diff --git a/compat/test/browser/suspense-hydration.test.js b/compat/test/browser/suspense-hydration.test.js
@@ -36,11 +36,23 @@ describe('suspense hydration', () => {
 		}
 	}
 
+	let resetAppendChild;
+	let resetInsertBefore;
+	let resetRemoveChild;
+	let resetRemove;
+
 	before(() => {
-		logCall(Element.prototype, 'appendChild');
-		logCall(Element.prototype, 'insertBefore');
-		logCall(Element.prototype, 'removeChild');
-		logCall(Element.prototype, 'remove');
+		resetAppendChild = logCall(Element.prototype, 'appendChild');
+		resetInsertBefore = logCall(Element.prototype, 'insertBefore');
+		resetRemoveChild = logCall(Element.prototype, 'removeChild');
+		resetRemove = logCall(Element.prototype, 'remove');
+	});
+
+	after(() => {
+		resetAppendChild();
+		resetInsertBefore();
+		resetRemoveChild();
+		resetRemove();
 	});
 
 	beforeEach(() => {

diff --git a/test/browser/fragments.test.js b/test/browser/fragments.test.js
@@ -38,9 +38,9 @@ describe('Fragment', () => {
 	let resetRemoveChild;
 
 	before(() => {
-		resetInsertBefore = logCall(Node.prototype, 'insertBefore');
-		resetAppendChild = logCall(Node.prototype, 'appendChild');
-		resetRemoveChild = logCall(Node.prototype, 'removeChild');
+		resetInsertBefore = logCall(Element.prototype, 'insertBefore');
+		resetAppendChild = logCall(Element.prototype, 'appendChild');
+		resetRemoveChild = logCall(Element.prototype, 'removeChild');
 		// logCall(CharacterData.prototype, 'remove');
 		// TODO: Consider logging setting set data
 		// ```
@@ -2571,9 +2571,7 @@ describe('Fragment', () => {
 		]);
 	});
 
-	// TODO: Revisit why this test is failing. Likely due to some side effect of
-	// the logCalls in suspense-hydration.test.js
-	it.skip('should properly place conditional elements around strictly equal vnodes', () => {
+	it('should properly place conditional elements around strictly equal vnodes', () => {
 		expectDomLog = true;
 		let set;
 

diff --git a/test/browser/lifecycles/shouldComponentUpdate.test.js b/test/browser/lifecycles/shouldComponentUpdate.test.js
@@ -20,9 +20,9 @@ describe('Lifecycle methods', () => {
 	let resetRemove;
 
 	before(() => {
-		resetInsertBefore = logCall(Node.prototype, 'insertBefore');
-		resetRemoveChild = logCall(Node.prototype, 'appendChild');
-		resetRemove = logCall(Node.prototype, 'removeChild');
+		resetInsertBefore = logCall(Element.prototype, 'insertBefore');
+		resetRemoveChild = logCall(Element.prototype, 'appendChild');
+		resetRemove = logCall(Element.prototype, 'removeChild');
 	});
 
 	after(() => {