Merge bba9fa7 into 65ae16e

preactjs · Sep 11, 2019 · d69ddba · d69ddba
2 parents 65ae16e + bba9fa7
commit d69ddba
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/diff/props.js b/src/diff/props.js
@@ -31,7 +31,7 @@ function setStyle(style, key, value) {
 		style.setProperty(key, value);
 	}
 	else {
-		style[key] = typeof value==='number' && IS_NON_DIMENSIONAL.test(key)===false ? value+'px' : value || '';
+		style[key] = typeof value==='number' && IS_NON_DIMENSIONAL.test(key)===false ? value+'px' : value==null ? '' : value;
 	}
 }
 

diff --git a/test/browser/render.test.js b/test/browser/render.test.js
@@ -422,6 +422,20 @@ describe('render()', () => {
 			}
 		});
 
+		it('should support opacity 0', () => {
+			render(<div style={{ opacity: 1 }}>Test</div>, scratch);
+			let style = scratch.firstChild.style;
+			expect(style)
+				.to.have.property('opacity')
+				.that.equals('1');
+
+			render(<div style={{ opacity: 0 }}>Test</div>, scratch);
+			style = scratch.firstChild.style;
+			expect(style)
+				.to.have.property('opacity')
+				.that.equals('0');
+		});
+
 		it('should replace previous style objects', () => {
 			render(<div style={{ display: 'inline' }}>test</div>, scratch);