Move event normalization to compat

preactjs · Mar 11, 2019 · ee3b692 · ee3b692
1 parent 1104fdb
commit ee3b692
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 8 deletions.
diff --git a/compat/src/index.js b/compat/src/index.js
@@ -199,6 +199,10 @@ function applyEventNormalization({ type, props }) {
 		props.ondblclick = props[newProps.ondoubleclick];
 		delete props[newProps.ondoubleclick];
 	}
+	if (newProps.onbeforeinput) {
+		props.onbeforeinput = props[newProps.onbeforeinput];
+		delete props[newProps.onbeforeinput];
+	}
 	// for *textual inputs* (incl textarea), normalize `onChange` -> `onInput`:
 	if (newProps.onchange && (type==='textarea' || (type.toLowerCase()==='input' && !/^fil|che|rad/i.test(props.type)))) {
 		let normalized = newProps.oninput || 'oninput';

diff --git a/compat/test/browser/index.test.js b/compat/test/browser/index.test.js
@@ -171,6 +171,13 @@ describe('preact-compat', () => {
 			expectToBeNormalized(<input {...props} type="text" />, '<input type="text">');
 
 		});
+
+		it('should normalize beforeinput event listener', () => {
+			let spy = sinon.spy();
+			render(<input onBeforeInput={spy} />, scratch);
+			scratch.firstChild.dispatchEvent(new Event('beforeinput'));
+			expect(spy).to.be.calledOnce;
+		});
 	});
 
 	describe('Component', () => {

diff --git a/src/diff/props.js b/src/diff/props.js
@@ -73,7 +73,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
 	else if (name[0]==='o' && name[1]==='n') {
 		let useCapture = name !== (name=name.replace(/Capture$/, ''));
 		let nameLower = name.toLowerCase();
-		name = (nameLower in dom || nameLower=='onbeforeinput' ? nameLower : name).substring(2);
+		name = (nameLower in dom ? nameLower : name).substring(2);
 
 		if (value) {
 			if (!oldValue) dom.addEventListener(name, eventProxy, useCapture);

diff --git a/test/browser/render.test.js b/test/browser/render.test.js
@@ -269,13 +269,6 @@ describe('render()', () => {
 		expect(scratch.firstChild.spellcheck).to.equal(false);
 	});
 
-	it('should attach beforeinput event listener', () => {
-		let spy = sinon.spy();
-		render(<input onBeforeInput={spy} />, scratch);
-		scratch.firstChild.dispatchEvent(new Event('beforeinput'));
-		expect(spy).to.be.calledOnce;
-	});
-
 	it('should apply string attributes', () => {
 		render(<div foo="bar" data-foo="databar" />, scratch);