Only run unmounting loop if there are any remaining children to unmou…

…nt (+2 B) (#4199)
preactjs · Nov 8, 2023 · f269b62 · f269b62
1 parent 9aa4728
commit f269b62
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/diff/children.js b/src/diff/children.js
@@ -323,14 +323,16 @@ function constructNewChildrenArray(newParentVNode, renderResult, oldChildren) {
 	// unmount DOM from the beginning of the oldChildren, we can adjust oldDom to
 	// point to the next child, which needs to be the first DOM node that won't be
 	// unmounted.
-	for (i = 0; i < oldChildrenLength; i++) {
-		oldVNode = oldChildren[i];
-		if (oldVNode != null && (oldVNode._flags & MATCHED) === 0) {
-			if (oldVNode._dom == newParentVNode._nextDom) {
-				newParentVNode._nextDom = getDomSibling(oldVNode);
-			}
+	if (remainingOldChildren) {
+		for (i = 0; i < oldChildrenLength; i++) {
+			oldVNode = oldChildren[i];
+			if (oldVNode != null && (oldVNode._flags & MATCHED) === 0) {
+				if (oldVNode._dom == newParentVNode._nextDom) {
+					newParentVNode._nextDom = getDomSibling(oldVNode);
+				}
 
-			unmount(oldVNode, oldVNode);
+				unmount(oldVNode, oldVNode);
+			}
 		}
 	}
 }