use options.unmount instead of overriding component.componentWillUnmount #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From the size bot: Size Change: +29 B (0%) Total Size: 42 kB
|
developit
reviewed
Jan 20, 2021
tanhauhau
force-pushed
the
tanlh/use-unmount-options
branch
from
76100c5
to
92664b9
Compare
tanhauhau
force-pushed
the
tanlh/use-unmount-options
branch
from
92664b9
to
5fffc2c
Compare
tanhauhau
force-pushed
the
tanlh/use-unmount-options
branch
from
5fffc2c
to
0802e6d
Compare
JoviDeCroock
approved these changes
Feb 9, 2021
|
Thank you so much for all the efforts @tanhauhau |
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #2917, use
options.unmountinstead of overridingcomponentWillUnmountthis will check
component._onResolveon every unmount though, not sure how much will this add up to slow things down