Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid source map with rollup 0.40 #800

Closed
tromey opened this issue Aug 7, 2017 · 3 comments
Closed

Invalid source map with rollup 0.40 #800

tromey opened this issue Aug 7, 2017 · 3 comments

Comments

@tromey
Copy link

tromey commented Aug 7, 2017

mozilla/source-map#247 mentions a source map problem with preact. A couple of the generated source maps are definitely wrong -- they refer to lines that don't appear in the generated file. I looked into this and found rollup/rollup#1254. Changing preact to require rollup 0.41 makes the bug go away.

@developit
Copy link
Member

Nice! Feel free to submit a PR that updates Rollup, otherwise I'll make sure that's in the next release.

@sbking
Copy link

sbking commented Sep 29, 2017

@developit This still seems to be an issue. I get the mentioned source map issue only when using preact, preventing me from using Webpack source maps in my production build.

@tromey Are you still seeing this issue?

@tromey
Copy link
Author

tromey commented Sep 29, 2017

@tromey Are you still seeing this issue?

I don't actually use preact; I just found this while investigating a bug filed against the source map library. So, I don't know, sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants