Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: don't call the callback or enqueue a render setState in constructor #1454

Merged
merged 2 commits into from Mar 25, 2019
Merged

fix: don't call the callback or enqueue a render setState in constructor #1454

merged 2 commits into from Mar 25, 2019

Conversation

JoviDeCroock
Copy link
Member

Fixes: #1402

@coveralls
Copy link

coveralls commented Mar 25, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 994827b on JoviDeCroock:fix/guardAgainstSetStateConstructor into 06e5b07 on developit:master.

marvinhagemeister
marvinhagemeister approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🚢 👍

@marvinhagemeister marvinhagemeister merged commit 8fe7800 into preactjs:master Mar 25, 2019
@JoviDeCroock JoviDeCroock deleted the fix/guardAgainstSetStateConstructor branch March 25, 2019 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoviDeCroock @coveralls @marvinhagemeister