Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary setting in tsconfig.json #1457

Merged
merged 1 commit into from Mar 26, 2019
Merged

Remove unnecessary setting in tsconfig.json #1457

merged 1 commit into from Mar 26, 2019

Conversation

38elements
Copy link
Contributor

strict includes noImplicitAny, noImplicitThis, and strictNullChecks.

https://www.typescriptlang.org/docs/handbook/compiler-options.html

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5dcb2dc on 38elements:tsconfig into 40a696f on developit:master.

marvinhagemeister
marvinhagemeister approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🎉👍

@marvinhagemeister marvinhagemeister merged commit 9276b09 into preactjs:master Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@38elements @coveralls @marvinhagemeister