Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compat/src/internal.d.ts #1483

Merged
merged 3 commits into from Mar 31, 2019
Merged

Fix compat/src/internal.d.ts #1483

merged 3 commits into from Mar 31, 2019

Conversation

38elements
Copy link
Contributor

No description provided.

@38elements 38elements marked this pull request as ready for review March 30, 2019 08:41
@coveralls
Copy link

coveralls commented Mar 30, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling ed3a151 on 38elements:compat-type into b84b873 on developit:master.

marvinhagemeister
marvinhagemeister approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome,thanks a bunch for updating the types 🎉 👍 Better autocompletion is always great to have 💯 💯

@marvinhagemeister marvinhagemeister merged commit efb5677 into preactjs:master Mar 31, 2019
@38elements 38elements deleted the compat-type branch April 1, 2019 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ForsakenHarmony ForsakenHarmony ForsakenHarmony left review comments

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@38elements @coveralls @marvinhagemeister @ForsakenHarmony