-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) - ensure correct unmount #1687
Conversation
Hmm, with the changes from @andrewiggins this change does not seem to be needed... Anyone sees a scenario where we should at it for safety? |
That's awesome! Even if the original issue is shady fixed by other changes in |
@marvinhagemeister would you like me to revert the change and just PR with the tests? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say let's check this PR as is. After working on my last PRs, I don't think_lastDomChild
should be used as proxy for determining if something is Fragment. Since all Components are Fragments now, we should directly check the type (i.e. typeof vnode.type === 'function'
) or the presence of _component
for behavior like this.
I went ahead and merged this cuz I'm building on top of it for my next PR |
Fixes: #1632
Adds a test for the wrong dom scenario (isn't fixed yet) but I aim at doing this in the future