Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a duplicate test in render tests (and add additional child node checks) #1847

Merged
merged 4 commits into from
Aug 10, 2019
Merged

Remove a duplicate test in render tests (and add additional child node checks) #1847

merged 4 commits into from
Aug 10, 2019

Conversation

OrKoN
Copy link
Contributor

@OrKoN OrKoN commented Aug 9, 2019

Removed a duplicate test and added assertions for the number of nodes to the similar tests

Following the discussion in #1821

@coveralls
Copy link

coveralls commented Aug 9, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.1%) to 99.876% when pulling 5dd018d on OrKoN:remove-duplicate-test into 97c0a2c on preactjs:master.

cristianbote
cristianbote approved these changes Aug 10, 2019
View reviewed changes
Copy link
Member

@cristianbote cristianbote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great! Hope you had fun vacationing 🌴! 😄

@ForsakenHarmony ForsakenHarmony merged commit 52ab905 into preactjs:master Aug 10, 2019
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Nov 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianbote cristianbote cristianbote approved these changes

@ForsakenHarmony ForsakenHarmony ForsakenHarmony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@OrKoN @coveralls @cristianbote @ForsakenHarmony