-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve code coverage and fix lint warnings #2041
Conversation
andrewiggins
commented
Oct 26, 2019
- Add tests for various sub-modules that modify the options object, verifying that they call previous options
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really awesome stuff here! I've been wondering if we should do more testing for options settings myself since starting to work on the devtools. Left a few minor comments, list me know what you think 👍💯
I'm building on top of this PR so going to go ahead and merge it in. Feel free to leave more comments. Just @-mention me if you do! |