Upgrade tests to use Babel 7 #2094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewiggins
commented
Nov 6, 2019
| @@ -0,0 +1,24 @@ | |||
| module.exports = function(api) { | |||
There was a problem hiding this comment.
babel-loader in the karma.config.js wasn't picking up the configuration in .babelrc but did work when I changed it to a babel.config.js. 🤷♂
| spyAll(Receiver); | ||
| spyAll(Receiver.prototype); |
There was a problem hiding this comment.
This tests failed unless I swapped the order here. Perhaps some new class transform broke the old form? 🤷♂
| } | ||
| ] | ||
| ] | ||
| ? [['istanbul', { include: '**/src/**/*.js' }]] |
marvinhagemeister
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm exploring writing a babel plugin to convert property names to enable our tests to run against the minified builds. In the process of doing that I realized that our tests still used Babel 6. This PR upgrades them to Babel 7.