Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of builds in actions #2476

Merged
merged 1 commit into from Apr 17, 2020
Merged

Conversation

andrewiggins
Copy link
Member

With the new prepare script, our current actions setup builds Preact 4 times:

Build Job:

  1. The build job runs npm ci which builds as part of the prepare script
  2. The build job then runs npm run build

Test Job:

  1. The test job runs npm ci which builds as part of the prepare script
  2. The test job then runs npm test which runs npm run build

Since this is redundant I've removed the npm run build step from the build jobs. However I left the extra build in test for now. I thought this might still be useful to support the development scenario where you make local changes and then run npm test to validate them. If npm test doesn't do a build, then developers need to update their habits to also do a build before running npm test, or else npm test will test the previous build without their changes.

Let me know what you think!

@github-actions
Copy link

Size Change: 0 B

Total Size: 39.2 kB

ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.12 kB 0 B
compat/dist/compat.module.js 3.14 kB 0 B
compat/dist/compat.umd.js 3.17 kB 0 B
debug/dist/debug.js 3 kB 0 B
debug/dist/debug.module.js 2.98 kB 0 B
debug/dist/debug.umd.js 3.08 kB 0 B
devtools/dist/devtools.js 185 B 0 B
devtools/dist/devtools.module.js 194 B 0 B
devtools/dist/devtools.umd.js 260 B 0 B
dist/preact.js 3.83 kB 0 B
dist/preact.min.js 3.83 kB 0 B
dist/preact.module.js 3.84 kB 0 B
dist/preact.umd.js 3.88 kB 0 B
hooks/dist/hooks.js 1.05 kB 0 B
hooks/dist/hooks.module.js 1.08 kB 0 B
hooks/dist/hooks.umd.js 1.12 kB 0 B
test-utils/dist/testUtils.js 437 B 0 B
test-utils/dist/testUtils.module.js 439 B 0 B
test-utils/dist/testUtils.umd.js 515 B 0 B

compressed-size-action

@github-actions
Copy link

Coverage Status

Coverage increased (+0.8%) to 99.801% when pulling 2c52dda on simplify-actions into d997846 on master.

Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Having faster CI runs is much appreciated 👍

Agree with your reasoning about keeping the build command in the test command.

@marvinhagemeister marvinhagemeister merged commit ce77f2d into master Apr 17, 2020
@marvinhagemeister marvinhagemeister deleted the simplify-actions branch April 17, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants