Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aria role attribute values #3904

Merged
merged 2 commits into from Feb 19, 2023
Merged

Add aria role attribute values #3904

merged 2 commits into from Feb 19, 2023

Conversation

shoonia
Copy link
Contributor

@shoonia shoonia commented Feb 18, 2023

Add typescript type for role attribute
https://www.w3.org/TR/wai-aria-1.1/#role_definitions

rschristian
rschristian reviewed Feb 19, 2023
View reviewed changes
src/jsx.d.ts Outdated Show resolved Hide resolved
@shoonia @rschristian
Update src/jsx.d.ts
65dabef 
Co-authored-by: Ryan Christian <33403762+rschristian@users.noreply.github.com>
@coveralls
Copy link

Coverage Status

Coverage: 99.548%. Remained the same when pulling 65dabef on shoonia:add-aria-role-type into c272b4e on preactjs:master.

JoviDeCroock
JoviDeCroock approved these changes Feb 19, 2023
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you!

@JoviDeCroock JoviDeCroock merged commit 17ce063 into preactjs:master Feb 19, 2023
@shoonia shoonia deleted the add-aria-role-type branch February 20, 2023 16:56
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
@JoviDeCroock
backport #3904
cdedefc
JoviDeCroock added a commit that referenced this pull request Jan 16, 2024
@JoviDeCroock
V11 update 10 13 (#4257)
4601cf3 
* backport #3911

* backport #3906

* backport #3837

* backport #3908

* backport #3904

* backport #3905

* backport #3898

* backport #3910

* backport #3948

* backport #3941

* backport #3945

* backport #3919

* backport #3922

* backport #3921

* backport #3903

* fix lint

* update more

* debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shoonia @coveralls @JoviDeCroock @rschristian