Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): perform value restoration async #4005

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

JoviDeCroock
Copy link
Member

Resolve #4004

As we are still traversing the tree or potentially have to invoke a diff we should wait until it completes before we restore the value

@coveralls
Copy link

Coverage Status

Coverage: 99.707% (+0.0009%) from 99.706% when pulling 0246e4b on delay-by-microtick into 8fe5401 on master.

@github-actions
Copy link

Size Change: +17 B (0%)

Total Size: 56.7 kB

Filename Size Change
compat/dist/compat.js 4.07 kB +6 B (0%)
compat/dist/compat.module.js 4 kB +6 B (0%)
compat/dist/compat.umd.js 4.14 kB +5 B (0%)
ℹ️ View Unchanged
Filename Size Change
debug/dist/debug.js 3.53 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 232 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 315 B 0 B
dist/preact.js 4.26 kB 0 B
dist/preact.min.js 4.29 kB 0 B
dist/preact.min.module.js 4.29 kB 0 B
dist/preact.min.umd.js 4.32 kB 0 B
dist/preact.module.js 4.29 kB 0 B
dist/preact.umd.js 4.33 kB 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.61 kB 0 B
jsx-runtime/dist/jsxRuntime.js 360 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 326 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 441 B 0 B
test-utils/dist/testUtils.js 442 B 0 B
test-utils/dist/testUtils.module.js 444 B 0 B
test-utils/dist/testUtils.umd.js 526 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit bcf365b into master May 16, 2023
4 checks passed
@JoviDeCroock JoviDeCroock deleted the delay-by-microtick branch May 16, 2023 15:09
JoviDeCroock added a commit that referenced this pull request May 18, 2023
JoviDeCroock added a commit that referenced this pull request May 18, 2023
* Revert "add delay by 1 microtick (#4005)"

This reverts commit bcf365b.

* revert controlled components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] Preact 10.14.0 breaks selection offset on controlled text inputs
3 participants