You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Been thinking about solutions for #2323, wrapping only when componentDidCatch is present does not work as we don't render other children then i.e. Suspense would lose the parallel capabilities and componentDidCatch would throw once when two children error...
@marvinhagemeister it will atleast reduce the stack a bit 😅 generally we might need to think of a way where we wrap _catchError/.. and only report the first stack we encounter, the thread has something about react and how they do it but need to look deeper into that
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Been thinking about solutions for #2323, wrapping only when
componentDidCatch
is present does not work as we don't render other children then i.e. Suspense would lose the parallel capabilities and componentDidCatch would throw once when two children error...Thinking about more ways we can improve this atm