Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call options.vnode on rerender #4209

Merged
merged 1 commit into from Nov 13, 2023
Merged

Call options.vnode on rerender #4209

merged 1 commit into from Nov 13, 2023

Conversation

andrewiggins
Copy link
Member

@andrewiggins andrewiggins commented Nov 13, 2023 •
edited

Should fix issues in Prefresh, specifically preactjs/prefresh#528

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2023 •
edited

📊 Tachometer Benchmark Results

Summary

duration

  • 02_replace1k: unsure 🔍 -0% - +2% (-0.27ms - +1.75ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -4% - +6% (-1.67ms - +2.80ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 -1% - +0% (-9.12ms - +3.59ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -2% - +5% (-0.60ms - +1.45ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.80ms - +1.96ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -1% - +2% (-0.37ms - +0.53ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -3% - +4% (-0.07ms - +0.11ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -1% - +0% (-0.21ms - +0.06ms)
    preact-local vs preact-main

usedJSHeapSize

  • 02_replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • 03_update10th1k_x16: unsure 🔍 -0% - +0% (-0.02ms - +0.00ms)
    preact-local vs preact-main
  • 07_create10k: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • filter_list: unsure 🔍 -0% - +2% (-0.01ms - +0.03ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -0% - +0% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • many_updates: unsure 🔍 -0% - +1% (-0.01ms - +0.05ms)
    preact-local vs preact-main
  • text_update: unsure 🔍 -1% - +1% (-0.01ms - +0.01ms)
    preact-local vs preact-main
  • todo: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main

Results

02_replace1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main83.73ms - 84.76ms-unsure 🔍
-2% - +0%
-1.75ms - +0.27ms		faster ✔
0% - 2%
0.18ms - 1.77ms
preact-local84.12ms - 85.86msunsure 🔍
-0% - +2%
-0.27ms - +1.75ms		-unsure 🔍
-2% - +1%
-1.29ms - +0.82ms
preact-hooks84.62ms - 85.82msslower ❌
0% - 2%
0.18ms - 1.77ms		unsure 🔍
-1% - +2%
-0.82ms - +1.29ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.32ms - 3.32ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
1% - 1%
0.02ms - 0.03ms
preact-local3.32ms - 3.32msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
1% - 1%
0.02ms - 0.03ms
preact-hooks3.34ms - 3.34msslower ❌
1% - 1%
0.02ms - 0.03ms		slower ❌
1% - 1%
0.02ms - 0.03ms		-

run-warmup-0

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main31.60ms - 32.89ms-faster ✔
0% - 6%
0.10ms - 1.86ms		unsure 🔍
-5% - +1%
-1.54ms - +0.31ms
preact-local32.63ms - 33.83msslower ❌
0% - 6%
0.10ms - 1.86ms		-unsure 🔍
-2% - +4%
-0.53ms - +1.27ms
preact-hooks32.19ms - 33.53msunsure 🔍
-1% - +5%
-0.31ms - +1.54ms		unsure 🔍
-4% - +2%
-1.27ms - +0.53ms		-

run-warmup-1

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main41.28ms - 42.59ms-unsure 🔍
-2% - +2%
-0.90ms - +1.01ms		unsure 🔍
-3% - +1%
-1.31ms - +0.62ms
preact-local41.19ms - 42.57msunsure 🔍
-2% - +2%
-1.01ms - +0.90ms		-unsure 🔍
-3% - +1%
-1.39ms - +0.59ms
preact-hooks41.57ms - 42.99msunsure 🔍
-1% - +3%
-0.62ms - +1.31ms		unsure 🔍
-1% - +3%
-0.59ms - +1.39ms		-

run-warmup-2

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main29.82ms - 30.27ms-unsure 🔍
-3% - +0%
-0.79ms - +0.10ms		faster ✔
1% - 3%
0.20ms - 0.89ms
preact-local30.01ms - 30.77msunsure 🔍
-0% - +3%
-0.10ms - +0.79ms		-unsure 🔍
-2% - +1%
-0.66ms - +0.26ms
preact-hooks30.33ms - 30.85msslower ❌
1% - 3%
0.20ms - 0.89ms		unsure 🔍
-1% - +2%
-0.26ms - +0.66ms		-

run-warmup-3

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main24.21ms - 24.87ms-unsure 🔍
-1% - +2%
-0.19ms - +0.50ms		unsure 🔍
-2% - +1%
-0.45ms - +0.25ms
preact-local24.29ms - 24.48msunsure 🔍
-2% - +1%
-0.50ms - +0.19ms		-faster ✔
0% - 2%
0.10ms - 0.40ms
preact-hooks24.52ms - 24.76msunsure 🔍
-1% - +2%
-0.25ms - +0.45ms		slower ❌
0% - 2%
0.10ms - 0.40ms		-

run-warmup-4

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main40.39ms - 41.72ms-unsure 🔍
-3% - +1%
-1.30ms - +0.47ms		unsure 🔍
-3% - +0%
-1.35ms - +0.19ms
preact-local40.88ms - 42.05msunsure 🔍
-1% - +3%
-0.47ms - +1.30ms		-unsure 🔍
-2% - +1%
-0.86ms - +0.53ms
preact-hooks41.25ms - 42.01msunsure 🔍
-0% - +3%
-0.19ms - +1.35ms		unsure 🔍
-1% - +2%
-0.53ms - +0.86ms		-

run-final

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main23.14ms - 23.65ms-unsure 🔍
-3% - +1%
-0.73ms - +0.15ms		faster ✔
1% - 5%
0.30ms - 1.14ms
preact-local23.32ms - 24.05msunsure 🔍
-1% - +3%
-0.15ms - +0.73ms		-unsure 🔍
-4% - +0%
-0.92ms - +0.06ms
preact-hooks23.78ms - 24.45msslower ❌
1% - 5%
0.30ms - 1.14ms		unsure 🔍
-0% - +4%
-0.06ms - +0.92ms		-
03_update10th1k_x16

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main45.06ms - 47.58ms-unsure 🔍
-6% - +4%
-2.80ms - +1.67ms		unsure 🔍
-4% - +4%
-1.96ms - +1.86ms
preact-local45.04ms - 48.73msunsure 🔍
-4% - +6%
-1.67ms - +2.80ms		-unsure 🔍
-4% - +6%
-1.82ms - +2.85ms
preact-hooks44.94ms - 47.80msunsure 🔍
-4% - +4%
-1.86ms - +1.96ms		unsure 🔍
-6% - +4%
-2.85ms - +1.82ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main3.28ms - 3.30ms-unsure 🔍
-0% - +0%
-0.00ms - +0.02ms		faster ✔
0% - 1%
0.00ms - 0.02ms
preact-local3.28ms - 3.29msunsure 🔍
-0% - +0%
-0.02ms - +0.00ms		-faster ✔
0% - 1%
0.01ms - 0.03ms
preact-hooks3.30ms - 3.31msslower ❌
0% - 1%
0.00ms - 0.02ms		slower ❌
0% - 1%
0.01ms - 0.03ms		-
07_create10k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1251.11ms - 1261.55ms-unsure 🔍
-0% - +1%
-3.59ms - +9.12ms		unsure 🔍
-1% - +0%
-8.60ms - +4.28ms
preact-local1249.94ms - 1257.18msunsure 🔍
-1% - +0%
-9.12ms - +3.59ms		-unsure 🔍
-1% - +0%
-10.16ms - +0.30ms
preact-hooks1254.71ms - 1262.27msunsure 🔍
-0% - +1%
-4.28ms - +8.60ms		unsure 🔍
-0% - +1%
-0.30ms - +10.16ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.32ms - 26.33ms-unsure 🔍
-0% - -0%
-0.01ms - -0.00ms		unsure 🔍
-0% - -0%
-0.02ms - -0.02ms
preact-local26.33ms - 26.33msunsure 🔍
+0% - +0%
+0.00ms - +0.01ms		-unsure 🔍
-0% - -0%
-0.02ms - -0.01ms
preact-hooks26.35ms - 26.35msunsure 🔍
+0% - +0%
+0.02ms - +0.02ms		unsure 🔍
+0% - +0%
+0.01ms - +0.02ms		-
filter_list

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main29.76ms - 31.10ms-unsure 🔍
-5% - +2%
-1.45ms - +0.60ms		unsure 🔍
-4% - +1%
-1.28ms - +0.39ms
preact-local30.08ms - 31.63msunsure 🔍
-2% - +5%
-0.60ms - +1.45ms		-unsure 🔍
-3% - +3%
-0.94ms - +0.90ms
preact-hooks30.38ms - 31.37msunsure 🔍
-1% - +4%
-0.39ms - +1.28ms		unsure 🔍
-3% - +3%
-0.90ms - +0.94ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main1.35ms - 1.37ms-unsure 🔍
-2% - +0%
-0.03ms - +0.01ms		faster ✔
1% - 4%
0.01ms - 0.05ms
preact-local1.36ms - 1.39msunsure 🔍
-0% - +2%
-0.01ms - +0.03ms		-unsure 🔍
-3% - -0%
-0.04ms - +0.00ms
preact-hooks1.38ms - 1.41msslower ❌
1% - 4%
0.01ms - 0.05ms		unsure 🔍
-0% - +3%
-0.00ms - +0.04ms		-
hydrate1k

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main133.15ms - 134.71ms-unsure 🔍
-1% - +1%
-1.96ms - +0.80ms		unsure 🔍
-2% - -0%
-2.59ms - +0.01ms
preact-local133.36ms - 135.64msunsure 🔍
-1% - +1%
-0.80ms - +1.96ms		-unsure 🔍
-2% - +1%
-2.26ms - +0.82ms
preact-hooks134.18ms - 136.26msunsure 🔍
-0% - +2%
-0.01ms - +2.59ms		unsure 🔍
-1% - +2%
-0.82ms - +2.26ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main6.10ms - 6.12ms-unsure 🔍
-0% - +0%
-0.01ms - +0.01ms		faster ✔
0% - 1%
0.02ms - 0.04ms
preact-local6.10ms - 6.11msunsure 🔍
-0% - +0%
-0.01ms - +0.01ms		-faster ✔
0% - 1%
0.02ms - 0.04ms
preact-hooks6.13ms - 6.14msslower ❌
0% - 1%
0.02ms - 0.04ms		slower ❌
0% - 1%
0.02ms - 0.04ms		-
many_updates

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.07ms - 26.63ms-unsure 🔍
-2% - +1%
-0.53ms - +0.37ms		unsure 🔍
-2% - +1%
-0.60ms - +0.18ms
preact-local26.07ms - 26.79msunsure 🔍
-1% - +2%
-0.37ms - +0.53ms		-unsure 🔍
-2% - +1%
-0.58ms - +0.32ms
preact-hooks26.28ms - 26.84msunsure 🔍
-1% - +2%
-0.18ms - +0.60ms		unsure 🔍
-1% - +2%
-0.32ms - +0.58ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main4.50ms - 4.54ms-unsure 🔍
-1% - +0%
-0.05ms - +0.01ms		faster ✔
0% - 1%
0.00ms - 0.06ms
preact-local4.52ms - 4.56msunsure 🔍
-0% - +1%
-0.01ms - +0.05ms		-unsure 🔍
-1% - +0%
-0.04ms - +0.02ms
preact-hooks4.53ms - 4.57msslower ❌
0% - 1%
0.00ms - 0.06ms		unsure 🔍
-0% - +1%
-0.02ms - +0.04ms		-
text_update

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main2.47ms - 2.59ms-unsure 🔍
-4% - +3%
-0.11ms - +0.07ms		faster ✔
7% - 13%
0.19ms - 0.37ms
preact-local2.48ms - 2.62msunsure 🔍
-3% - +4%
-0.07ms - +0.11ms		-faster ✔
6% - 12%
0.16ms - 0.35ms
preact-hooks2.74ms - 2.88msslower ❌
7% - 15%
0.19ms - 0.37ms		slower ❌
6% - 14%
0.16ms - 0.35ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.77ms - 0.78ms-unsure 🔍
-1% - +1%
-0.01ms - +0.01ms		faster ✔
1% - 4%
0.01ms - 0.03ms
preact-local0.77ms - 0.78msunsure 🔍
-1% - +1%
-0.01ms - +0.01ms		-faster ✔
1% - 4%
0.01ms - 0.03ms
preact-hooks0.78ms - 0.80msslower ❌
1% - 4%
0.01ms - 0.03ms		slower ❌
1% - 4%
0.01ms - 0.03ms		-
todo

duration

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main26.63ms - 26.83ms-unsure 🔍
-0% - +1%
-0.06ms - +0.21ms		faster ✔
3% - 4%
0.74ms - 1.02ms
preact-local26.56ms - 26.74msunsure 🔍
-1% - +0%
-0.21ms - +0.06ms		-faster ✔
3% - 4%
0.83ms - 1.08ms
preact-hooks27.52ms - 27.70msslower ❌
3% - 4%
0.74ms - 1.02ms		slower ❌
3% - 4%
0.83ms - 1.08ms		-

usedJSHeapSize

VersionAvg timevs preact-mainvs preact-localvs preact-hooks
preact-main0.79ms - 0.79ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms		faster ✔
3% - 3%
0.02ms - 0.02ms
preact-local0.79ms - 0.79msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-faster ✔
3% - 3%
0.02ms - 0.02ms
preact-hooks0.82ms - 0.82msslower ❌
3% - 3%
0.02ms - 0.02ms		slower ❌
3% - 3%
0.02ms - 0.02ms		-

tachometer-reporter-action v2 for Benchmarks

@coveralls
Copy link

coveralls commented Nov 13, 2023 •
edited

Coverage Status

coverage: 99.463%. remained the same
when pulling da7f2c0 on options-vnode-on-rerender
into 2f31796 on main.

@github-actions GitHub Actions
Copy link

Size Change: +74 B (0%)

Total Size: 59.6 kB

Filename Size Change
dist/preact.js 4.48 kB +8 B (0%)
dist/preact.min.js 4.52 kB +13 B (0%)
dist/preact.min.module.js 4.51 kB +13 B (0%)
dist/preact.min.umd.js 4.54 kB +14 B (0%)
dist/preact.module.js 4.5 kB +10 B (0%)
dist/preact.umd.js 4.56 kB +16 B (0%)
ℹ️ View Unchanged
Filename Size Change
compat/dist/compat.js 3.98 kB 0 B
compat/dist/compat.module.js 3.9 kB 0 B
compat/dist/compat.umd.js 4.04 kB 0 B
debug/dist/debug.js 3.52 kB 0 B
debug/dist/debug.module.js 3.52 kB 0 B
debug/dist/debug.umd.js 3.6 kB 0 B
devtools/dist/devtools.js 231 B 0 B
devtools/dist/devtools.module.js 240 B 0 B
devtools/dist/devtools.umd.js 314 B 0 B
hooks/dist/hooks.js 1.53 kB 0 B
hooks/dist/hooks.module.js 1.56 kB 0 B
hooks/dist/hooks.umd.js 1.62 kB 0 B
jsx-runtime/dist/jsxRuntime.js 963 B 0 B
jsx-runtime/dist/jsxRuntime.module.js 938 B 0 B
jsx-runtime/dist/jsxRuntime.umd.js 1.04 kB 0 B
test-utils/dist/testUtils.js 453 B 0 B
test-utils/dist/testUtils.module.js 454 B 0 B
test-utils/dist/testUtils.umd.js 536 B 0 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 056a890 into main Nov 13, 2023
15 checks passed
@JoviDeCroock JoviDeCroock deleted the options-vnode-on-rerender branch November 13, 2023 05:07
@JoviDeCroock
Copy link
Member

@marvinhagemeister is it possible that this messed with devtools as well?

@JoviDeCroock JoviDeCroock mentioned this pull request Nov 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewiggins @coveralls @JoviDeCroock