Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some sensible timeouts to actions that call out to external services #4259

Merged
merged 1 commit into from Jan 22, 2024
Merged

Add some sensible timeouts to actions that call out to external services #4259

merged 1 commit into from Jan 22, 2024

Conversation

andrewiggins
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

coverage: 99.473%. remained the same
when pulling b5cb9ba on gha-timeouts
into b3480e8 on main.

rschristian
rschristian approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@rschristian rschristian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shout, that 6hr default on saucelabs is a bit crazy

@JoviDeCroock JoviDeCroock merged commit 79be156 into main Jan 22, 2024
4 checks passed
@JoviDeCroock JoviDeCroock deleted the gha-timeouts branch January 22, 2024 12:07
@JoviDeCroock JoviDeCroock mentioned this pull request Feb 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@rschristian rschristian rschristian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andrewiggins @coveralls @marvinhagemeister @JoviDeCroock @rschristian